Add a model section #220
Merged
Add a model section #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrielsanbrito
left a comment
gabrielsanbrito
left a comment
There was a problem hiding this comment.
@nondebug left a couple of comments. I think that the model section looks good!
gabrielsanbrito
approved these changes
Jun 3, 2025
Collaborator
gabrielsanbrito
left a comment
gabrielsanbrito
left a comment
There was a problem hiding this comment.
Sorry for the long delay. I gave it a last pass and I think that the model section looks good. Just added 2 comments, which are basically questions. Thanks for making it so detailed!
| time. A [=touch point=] has a <dfn>touch x coordinate</dfn> | ||
| and a <dfn>touch y coordinate</dfn> representing the position in the [=touch surface=]'s coordinate system. | ||
| If a [=touch surface=] is on the top, bottom, front, or back side of the [=gamepad=] then the [=touch x coordinate=] is measured along the left-right axis, otherwise it is measured along the top-bottom axis. | ||
| The [=touch y coordinate=] is measured along the perpendicular axis. |
Collaborator
There was a problem hiding this comment.
Should we mention anything about the orientation of the y-axis?
Collaborator
Author
There was a problem hiding this comment.
We should, since the current spec is ambiguous about which way is +Y. For other axes we define this in the normalization steps, let's do the same for touch coordinates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #???
The following tasks have been completed:
Implementation commitment:
Preview | Diff