Skip to content

Add the option to use the glyf transform from woff2 when encoding a patch. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garretrieger wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add the option to use the glyf transform from woff2 when encoding a patch. #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d650f80
Add a transformer which can apply woff2 glyf and loca transformations…
garretrieger Oct 27, 2020
3f19219
Add glyf/loca transformation support to the patch subset server.
garretrieger Oct 28, 2020
147ef44
Handle empty subsets in the glyf transformer.
garretrieger Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions patch_subset/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,23 @@ cc_library(
"frequency_codepoint_predictor.cc",
"harfbuzz_subsetter.cc",
"noop_codepoint_predictor.h",
"noop_glyf_transformer.h",
"patch_subset_server_impl.cc",
"simple_codepoint_mapper.cc",
"woff2_glyf_transformer.cc",
],
hdrs = [
"codepoint_mapper.h",
"codepoint_mapping_checksum.h",
"codepoint_mapping_checksum_impl.h",
"codepoint_predictor.h",
"frequency_codepoint_predictor.h",
"glyf_transformer.h",
"harfbuzz_subsetter.h",
"patch_subset_server_impl.h",
"simple_codepoint_mapper.h",
"subsetter.h",
"woff2_glyf_transformer.h",
],
data = [
"//analysis/pfe_methods/unicode_range_data:slicing_strategies",
Expand All @@ -52,6 +56,7 @@ cc_library(
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/strings",
"@harfbuzz",
"@woff2",
],
)

Expand Down Expand Up @@ -146,13 +151,15 @@ cc_test(
"mock_codepoint_mapping_checksum.h",
"mock_codepoint_predictor.h",
"mock_font_provider.h",
"mock_glyf_transformer.h",
"mock_hasher.h",
"mock_patch_subset_server.h",
"patch_subset_client_test.cc",
"patch_subset_server_impl_test.cc",
"server_integration_test.cc",
"simple_codepoint_mapper_test.cc",
"sparse_bit_set_test.cc",
"woff2_glyf_transformer_test.cc",
],
data = [
":testdata",
Expand Down
7 changes: 5 additions & 2 deletions patch_subset/client_server_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "patch_subset/harfbuzz_subsetter.h"
#include "patch_subset/hb_set_unique_ptr.h"
#include "patch_subset/noop_codepoint_predictor.h"
#include "patch_subset/noop_glyf_transformer.h"
#include "patch_subset/null_request_logger.h"
#include "patch_subset/patch_subset.pb.h"
#include "patch_subset/patch_subset_client.h"
Expand All @@ -35,7 +36,8 @@ class PatchSubsetClientServerIntegrationTest : public ::testing::Test {
std::unique_ptr<Hasher>(new FarmHasher()),
std::unique_ptr<CodepointMapper>(nullptr),
std::unique_ptr<CodepointMappingChecksum>(nullptr),
std::unique_ptr<CodepointPredictor>(new NoopCodepointPredictor())),
std::unique_ptr<CodepointPredictor>(new NoopCodepointPredictor()),
std::unique_ptr<GlyfTransformer>(new NoopGlyfTransformer())),
client_(&server_, &request_logger_,
std::unique_ptr<BinaryPatch>(new BrotliBinaryPatch()),
std::unique_ptr<Hasher>(new FarmHasher())),
Expand All @@ -49,7 +51,8 @@ class PatchSubsetClientServerIntegrationTest : public ::testing::Test {
std::unique_ptr<CodepointMapper>(new SimpleCodepointMapper()),
std::unique_ptr<CodepointMappingChecksum>(
new CodepointMappingChecksumImpl(hasher_.get())),
std::unique_ptr<CodepointPredictor>(new NoopCodepointPredictor())),
std::unique_ptr<CodepointPredictor>(new NoopCodepointPredictor()),
std::unique_ptr<GlyfTransformer>(new NoopGlyfTransformer())),
client_with_mapping_(
&server_with_mapping_, &request_logger_,
std::unique_ptr<BinaryPatch>(new BrotliBinaryPatch()),
Expand Down
Loading