Refactor GroqModel to Data Class for Custom IDs (Syntax-Level Compatibility) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyfor
requested changes
Apr 16, 2025
Owner
vyfor
left a comment
vyfor
left a comment
There was a problem hiding this comment.
Looks good! I've eyeballed the necessary changes for now, will test everything later and update you.
Introduce unit tests to ensure correct serialization and deserialization of the `GroqModel` class. Updated `GroqModel` to use a Kotlin `value class` for efficiency and modified Gradle configuration to centralize test dependencies in `commonTest`.
vyfor
approved these changes
Apr 18, 2025
Owner
vyfor
left a comment
vyfor
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Enable custom GroqModel IDs. Backward compatibility is primarily syntax-level.
What
Changed GroqModel from enum to data class. Retained existing constants (e.g., GroqModel.LLAMA_3_8B_8192) as pre-defined instances.
How
Existing code using constants compiles. Important: Address potential compatibility issues in serialization, configuration, API interactions, and type safety. Requires thorough testing and potential migration efforts.