Extend on-leave and on-enter to sketch windows#135
Open
swapneils wants to merge 2 commits intovydd:masterfrom
Open
Extend on-leave and on-enter to sketch windows#135swapneils wants to merge 2 commits intovydd:masterfrom
on-leave and on-enter to sketch windows#135swapneils wants to merge 2 commits intovydd:masterfrom
Conversation
Owner
|
Hey, @swapneils, thank you for the PR! Could you please provide an example sketch describing the demonstrated behavior before, and expected behavior after? |
Author
|
Here's one example. In the code as written we shouldn't be triggering the on-enter and on-leave methods, since on-hover only has advice for entity instances, and sketch is a direct child of standard-object instead. In this PR the methods activate appropriately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was toying around with
show-cursorandhide-cursorfromcl-sdl2, and found that running 2 different sketches with different settings for this led to them competing for control of cursor visibility.Presumably SDL2's choice to make these kinds of things global variables means that many other effects have the same issue. Extending
on-leaveandon-enterto sketch windows could allow tracking of which sketch has mouse-focus, to better filter when to call these methods.