Corrige query e service da dashboard kpis

[lucas-oristanio]

No description provided.

[Copilot]

Pull Request Overview

This PR corrects the dashboard KPI queries and service logic to produce accurate metrics, and adjusts the scheduling frequency for insight fetching.

• Updated InsightsScheduler to run every 5 minutes instead of hourly.
• Refactored DashboardService to use new aggregated repository methods and recalculate KPI rates in code.
• Added two new repository queries for basic metrics and last-post reach, and updated the controller to match the new service signature.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
InsightsScheduler.java	Changed cron expression to 0 */5 * * * * for more frequent runs
DashboardService.java	Updated method signature, query results parsing, and KPI math
DashboardRepository.java	Added findMetricasBasicas and findAlcanceUltimoPost queries
DashboardControllerImpl.java	Adjusted null-check and updated call to new service signature

Comments suppressed due to low confidence (6)

src/main/java/com/vulpix/api/service/DashboardService.java:72

• [nitpick] Changing the signature to accept only a UUID may break existing callers; ensure all consumers are updated or consider providing an overloaded version for backward compatibility.

public DashKpiDto buscaKpisPorPeriodo(UUID empresaId) {

src/main/java/com/vulpix/api/repository/DashboardRepository.java:147

• [nitpick] Since this query always returns a single row per empresa, you might return an Optional<Object[]> or Object[] directly to make the method contract clearer.

List<Object[]> findMetricasBasicas(@Param("empresa_id") UUID empresaId);

src/main/java/com/vulpix/api/service/DashboardService.java:86

• Add unit tests covering KPI calculations—particularly for zero-impression scenarios—to ensure both taxaCompartilhamento and taxaSaves behave correctly.

BigDecimal taxaCompartilhamento = totalImpressoes > 0

src/main/java/com/vulpix/api/service/DashboardService.java:87

• [nitpick] Consider extracting the literal "100" into a named constant (e.g., PERCENT_MULTIPLIER) to clarify its purpose and avoid magic numbers.

new BigDecimal("100").multiply(new BigDecimal(totalShares))

src/main/java/com/vulpix/api/service/integracoes/graph/InsightsScheduler.java:28

• [nitpick] Running the scheduler every 5 minutes may increase load; consider externalizing this cron expression into configuration or validating that this frequency is intended.

@Scheduled(cron = "0 */5 * * * *")

src/main/java/com/vulpix/api/service/DashboardService.java:99

• Verify that the order of arguments in this DashKpiDto constructor matches the DTO definition to avoid misaligned KPI values.

return new DashKpiDto(

[ezpmartins]

Nice