Hotfix get metrics #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This hotfix removes the "impressions" metric from the API calls that fetch post insights.
- Removed "impressions" from the query parameters in PublicacaoService.
- Removed the "impressions" case handling in InsightService to align with upstream API changes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/vulpix/api/service/integracoes/graph/PublicacaoService.java | Removed "impressions" from the metrics parameter in the API URL. |
| src/main/java/com/vulpix/api/service/integracoes/graph/InsightService.java | Removed "impressions" from the batch request and eliminated corresponding metric handling. |
Comments suppressed due to low confidence (2)
src/main/java/com/vulpix/api/service/integracoes/graph/PublicacaoService.java:304
- Ensure that the removal of the 'impressions' metric from query parameters is intentional and that downstream services or documentation are updated to reflect this change.
.queryParam("metric", "reach,likes,comments,shares,saved,profile_visits")
src/main/java/com/vulpix/api/service/integracoes/graph/InsightService.java:107
- Since the 'impressions' metric has been removed from the metric query, remove or refactor any related logic (such as the impressions handling case) in InsightService to avoid dead code.
case "impressions":
ezpmartins
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.