fix: use HTML Living Standard comment syntax#212
Open
acid-chicken wants to merge 1 commit intovuejs:masterfrom
Open
fix: use HTML Living Standard comment syntax#212acid-chicken wants to merge 1 commit intovuejs:masterfrom
acid-chicken wants to merge 1 commit intovuejs:masterfrom
Conversation
Author
|
found a related PR on Vetur, fyi: vuejs/vetur#1052 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, double-hyphens (
--) inside comments aren't allowed in the linguist syntax highlight. However, the parser allows them without any warnings.The SFC Spec says "use HTML comment syntax" but HTML comment syntax definition is little ambiguous. HTML Living Standard allows to use double-hyphens inside, however, contrarily HTML 4.01 and past forbid it. Current vue-syntax-highlight seems refering the latter spec, but the actual parser implementation follows the former spec.
This change adjusts vue-syntax-highlight definitions to vue's compiler/parser/html-parser behavior.