-
Notifications
You must be signed in to change notification settings - Fork 58
WIP: feat: Character sheet for v2 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyrmisis
commented
Jun 4, 2023
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, why the heck is this in here? Hahaha ignore this, I apparently, accidentally, picked up @anthonyronda 's work.
… they create Use data attributes to do this (ex: data-treasure for items, data-lvl for spells)
…for levels you already have
…r toggle the item row
…ber, rather than a string
…turate their backgrounds
…o chat without casting.
…orking after WC changes
Collaborator
Author
|
Closing in favor of #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This changeset represents my proposal for a way to build UI elements for the new v2 character sheet.
Of note: it makes use of the Custom Element spec and constructed stylesheets to encapsulate functionality and styling in components.
Please, please, please chime in on this. It's nowhere near done, and that's intentional; I want to get feedback on this approach, because it very much is not something the Foundry dev community uses (outside of stuff like tagify).
What's left?