fix: actor entity tweaks #375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: async restores treasure result text * fix: avoid race conditions with flag "async:false"
* fix: On dropping item onto actor, check for existence before checking for anything related to containers * fix: Remove pre-container-data-model code for handling containers on monsters * fix: Programmers and linguists agree: Why Plurals?
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* fix: Add missing usesAscendingAC key * fix: Update deprecated code * fix: use game.system.id instead of OSE.systemName when getting party members
feat: Add linting
chore: A taste of linting (ose.js, ose.scss.js, == to ===)
* fix: async restores treasure result text (vttred#272) * fix: async restores treasure result text * fix: avoid race conditions with flag "async:false" * fix: Monster Data Model bugfixes (vttred#279) * fix: On dropping item onto actor, check for existence before checking for anything related to containers * fix: Remove pre-container-data-model code for handling containers on monsters * fix: Programmers and linguists agree: Why Plurals? * fix: don't reroll on round 1 if already rolled (vttred#280) * Create CNAME * docs: add Haxxer as a contributor for code (vttred#281) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fix(temporary): removed caching from the build ci * fix: AC/AAC display fix + party overview fix (vttred#286) * fix: Add missing usesAscendingAC key * fix: Update deprecated code * fix: use game.system.id instead of OSE.systemName when getting party members * fix: Additional v1.7.x fixes (vttred#289) * fix: Character generator now properly sets scores * fix: Items should once again properly display their descriptions. * fix: Treasure items should be created under the Treasure inventory heading * fix: Item and armor descriptions should target the correct fields * fix: replaced broken chart with "translated" badge * chore: update README to where people can find the Discord invite * feat: add Catalan and Chinese support to manifest * Updates to Item Piles system integration (vttred#292) * Updates to system integration * Added unstackable item types * [enhancement] Added option to revert Ctrl/Meta behavior (vttred#294) * [enhancement] Added option to revert Ctrl/Meta behavior * Extracted skipDialogCheck to method * Removed comment about monster testing. * Moved skipRollDialogcheck to helper collection * cleanup Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com> * docs: add bakbakbakbakbak as a contributor for code (vttred#302) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add adn770 as a contributor for translation (vttred#303) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * [enhancement] Container delete confirmation (vttred#299) * [enhancement] Added confirmation when deleting containers containing items * [fix] Container now pushes out containing items. * Changed to Dialog.confirm * Cleanup * cleanup * Allow first item check condition to allow no item Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com> * fix: shopping cart now deducts gold * Remove confusing monster options (vttred#308) Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com> * [fix] Correctly creating link anchors in TextEditor & dragging items to hotbar (vttred#304) * [fix] Use item.getDragData to fix bad link * [fix] Macro creation when dragging item from actor * Fixed macro warning for non-actor items * Tests for item macros * Cleanup * Unlinked token macro fix * Fixed typo in en.json * Fixed bug on row 67 * Non-destructive macro removal * Macro logic * Cleanup Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com> * fix: Macro for same item name now creates Co-authored-by: Anthony Ronda <anthonyronda@gmail.com> Co-authored-by: Tim <tim.snyder.work@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Adam Oresten <adamoresten@gmail.com> Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com>
chore(test): (almost) all up to sheet level
…test fix: entity-tweaks-tests
fix(macro): Allow macro to be dragged to hotbar for 1.8.x
fix(config): tag images not set correctly for 1.8.x
* fix(party): Fix recursive folder adding * fix: Actor, not Folder --------- Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com>
* fix(item): Make spendSpell async * cleanup & lint --------- Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com>
* fix: dice rolling fixes * chore(test): dice rolling * chore(test): sendAttackRoll cleanup * chore(desc): Added description to attackIsSuccess * Added descriptions to helpers-dice.js * chore(test): Added tests for issue vttred#340 * chore(desc): Better test descriptions for vttred#340 * cleanup * fix(dice): Always allow hit when untargeted, vttred#333 * cleanup --------- Co-authored-by: bakbakbakbakbak <bakbakbakbak@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
defaultOptionsfailing tests in #356Keeping it in draft until #356 is merged.