Fix eval helper to match VTEX's implementation #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were extra spaces in the regex inside the eval helper that made it behave differently from VTEX's actual eval helper (probably due to code autoformatting).
jpesce
changed the title
Author
|
Hi @georgebrindeiro! Any interest in merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are extra spaces (probably due to code autoformatting) in the regex inside the eval helper that make it behave differently from VTEX's actual eval helper. This PR fixes this.
Tests
Here's the result of the expression
{{eval "'${string}'.split(' ')[0]" string=_accountInfo.CompanyName}}inside an 'Order Confirmation' template on a VTEX production environment:Here's the result in the current version of
vtex-emails(before this fix):Here's the result after the fix:
