feat: add Twitter meta tags to product page#530
feat: add Twitter meta tags to product page#530edyespinal wants to merge 10 commits intovtex-apps:masterfrom
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
…ayed when enabled
victorhmp
left a comment
There was a problem hiding this comment.
Could you update the CHANGELOG file?
Also, please take a look into why the tests are failing. It's probably because there's no mock definition for vtex.twitter-meta-tags :)
igorbrasileiro
left a comment
There was a problem hiding this comment.
Thank you @edyespinal for the contribution 👏 !
Left some comments take a look at it.
Remove unnecessary blank line. Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
| "description": "admin/store.twitterUsername.description", | ||
| "type": "string" | ||
| }, | ||
| "twitterCard": { |
There was a problem hiding this comment.
Hi @victorhmp
I was doing a little digging to see what is causing the issue of the title and description not being displayed and the dropdown not having the correct style.
I noticed that we are using react-jsonschema-form to construct the store settings (for the apps' settings as well).
After reading the documentation, I don't see what we are doing wrong here. Maybe it's something when the VTEX Styleguide is being applied to the components.
After testing the same settings inside an apps settings form, this is what we get:
Screen.Recording.2021-09-16.at.14.49.45.mov
When testing the settings directly with react-jsonschema-form, this is what we get:
Screen.Recording.2021-09-16.at.14.44.18.mov
As you can see, in both cases the title and the description is displayed and the dropbox is styled correctly.
What should we do?
There was a problem hiding this comment.
@edyespinal this is awesome! Great investigation!
I have an idea! Could you try importing the Dropdown component from react/components/form/Dropdown and adding it to the widgets object created here? This might just do it!
There was a problem hiding this comment.
Hi @victorhmp
I tried your approach but we are still getting the same results.
There was a problem hiding this comment.
Hi team!
Is there anything else we need to do about this app?
Co-authored-by: Victor Hugo Miranda Pinto <victor2142@gmail.com>
…l/store into feat/twitter-meta-tags
|
I think we need to solve this problem where the label of the field is not being shown before releasing the feature. |
|
Hi @davicostalf 👋🏼
Is there a workaround we can implement for this while the issue is fixed?
Yes, we took your comment into consideration and made the change. You can see it here. Also, the message was changed by removing the |
|
Hey team! |

What problem is this solving?
This PR adds the possibility to add Twitter meta tags to a store's Product Page. The tags can be included by toggling the option in
Admin > CMS > StoreThe meta tags that are being added are the following:
The settings added to the store's settingsSchema for this app can be found here and the logic to add the
meta tagscan be found here.How to test it?
The Twitter Meta Tags and the Store apps are linked in this workspace.
To test it, make sure the
includeTwitterMetaTagstoggle is checked and add the Twitter Username and Twitter Card text fields are filled. Then visit any product page and look check for the Meta Tags that are being added.Screenshots or example usage: