Skip to content

Revert "Merge pull request #730 from vtex-apps/chore/revert-ads-sdk-pr"#731

Merged
MatheusLealv merged 2 commits intomasterfrom
feat/reapply-ads-sdk
Dec 15, 2025
Merged

Revert "Merge pull request #730 from vtex-apps/chore/revert-ads-sdk-pr"#731
MatheusLealv merged 2 commits intomasterfrom
feat/reapply-ads-sdk

Conversation

@MatheusLealv
Copy link
Copy Markdown
Contributor

What problem is this solving?

This reverts commit bc18f9f, reversing changes made to 15d68bf.

After deploying #711 it led to the INC-4666
and we immediately rolled it back through these steps

  1. vtex deprecate
  2. revert the PR 711

After investigating, we discovered that the issue was some publishers didn't have the publisherId variable settings correctly setup and it was triggering an error in Ads-SDK because the context AdsProvider was not correctly set in the store app because publisherId was empty [ref Store-App]

How to test it?

Since this PR is the same as 711, the test and example of usage are already explainned here:
#711

@MatheusLealv MatheusLealv requested review from a team as code owners December 9, 2025 14:03
@MatheusLealv MatheusLealv requested review from gabpaladino, leo-prange-vtex and vsseixaso and removed request for a team December 9, 2025 14:03
@vtex-io-docs-bot
Copy link
Copy Markdown

vtex-io-docs-bot bot commented Dec 9, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd bot commented Dec 9, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@MatheusLealv MatheusLealv merged commit c1deb1a into master Dec 15, 2025
10 checks passed
@MatheusLealv MatheusLealv deleted the feat/reapply-ads-sdk branch December 15, 2025 16:13
@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd bot commented Dec 15, 2025

Your PR has been merged! App is being published. 🚀
Version 3.142.0 → 3.143.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-result@3.143.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants