Revert "Merge pull request #730 from vtex-apps/chore/revert-ads-sdk-pr"#731
Revert "Merge pull request #730 from vtex-apps/chore/revert-ads-sdk-pr"#731MatheusLealv merged 2 commits intomasterfrom
Conversation
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
This reverts commit bc18f9f, reversing changes made to 15d68bf.
After deploying #711 it led to the INC-4666
and we immediately rolled it back through these steps
After investigating, we discovered that the issue was some publishers didn't have the publisherId variable settings correctly setup and it was triggering an error in Ads-SDK because the context AdsProvider was not correctly set in the store app because publisherId was empty [ref Store-App]
How to test it?
Since this PR is the same as 711, the test and example of usage are already explainned here:
#711