fix: prevent fetch loops with call tracking and caching (#26)#36
Merged
fix: prevent fetch loops with call tracking and caching (#26)#36
Conversation
…e-enable (#26) - Remove doom_loop: 'allow' to re-enable OpenCode's built-in loop detection - Add fetch-tracker hook that counts per-URL calls per session - Cache fetch results with LRU eviction (50 entries, 5min TTL) - Inject warnings after 3 repeated calls to same resource - Hard-block after 5 repeated calls with informative message - Track webfetch, context7_query-docs, context7_resolve-library-id, btca_ask - Session-scoped state with cleanup on session delete Closes #26
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/hooks/fetch-tracker.ts">
<violation number="1" location="src/hooks/fetch-tracker.ts:190">
P1: Max-call blocking is gated by cache-hit conditions, so repeated fetches can bypass the hard block when cache is expired/missing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26 — agents entering infinite loops fetching the same web documents repeatedly.
doom_loop: "allow"was set as collateral ine4c2f47when all permissions were blanket-allowed. Removing it restores OpenCode's built-in loop protection.webfetch,context7_query-docs,context7_resolve-library-id,btca_ask.26 new tests, all passing. No changes to existing test results.