Left/right document isolated view with hotkeys #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vslavik
requested changes
Dec 23, 2025
Comment on lines
+611
to
+616
| toolbar->AddTool(ID_LEFT_DOC, "Left document", BMP_ARTPROV(wxART_GO_BACK), | ||
| "Show left document (Ctrl <)"); | ||
| toolbar->AddTool(ID_DIFF_DOC, "Diff document", BMP_ARTPROV(wxART_REDO), | ||
| "Show diff document (Ctrl d)"); | ||
| toolbar->AddTool(ID_RIGHT_DOC, "Right document", BMP_ARTPROV(wxART_GO_FORWARD), | ||
| "Show right document (Ctrl >)"); |
Owner
There was a problem hiding this comment.
These icons seem arbitrary — and semantically incorrect.
| switch ( m_display_mode ) | ||
| { | ||
| case SHOW_LEFT_DOCUMENT: | ||
| // |
Comment on lines
+723
to
+738
| if ( img1 ) | ||
| m_viewer->Set(img1); | ||
| else if ( img2 ) | ||
| m_viewer->Set(img2); | ||
| else | ||
| m_viewer->Set(NULL); | ||
| break; | ||
|
|
||
| case SHOW_RIGHT_DOCUMENT: | ||
| if ( img2 ) | ||
| m_viewer->Set(img2); | ||
| else if ( img1 ) | ||
| m_viewer->Set(img1); | ||
| else | ||
| m_viewer->Set(NULL); | ||
| break; |
Owner
There was a problem hiding this comment.
I don’t understand why this code shows left-side image on the right side and vice versa?
Comment on lines
+838
to
+839
| m_offset = wxPoint(0, 0); | ||
| DoUpdatePage(); |
Owner
There was a problem hiding this comment.
Why do these reset the offset — seems unrelated?
Please also don’t duplicate code like this, use a helper function.
Comment on lines
+886
to
+888
| EVT_TOOL (ID_LEFT_DOC, DiffFrame::OnShowLeftDocument) | ||
| EVT_TOOL (ID_DIFF_DOC, DiffFrame::OnShowDiffDocument) | ||
| EVT_TOOL (ID_RIGHT_DOC, DiffFrame::OnShowRightDocument) |
Owner
There was a problem hiding this comment.
Wrong indentation, D is not aligned.
| It is also possible to shift the two pages relatively to each other using | ||
| Ctrl-arrows (Cmd-arrows on MacOS). This is useful for identifying translation-only differences. | ||
|
|
||
| You can also use Ctrl < and Ctrl > (Cmd < and Cmd > on MacOS) show the left and right documents respecively. Ctrl d to return back to the diff view. |
Owner
There was a problem hiding this comment.
Please use the standard way of referring to combined keypresses, which is Ctrl+D etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the red/blue diff view is a bit confusing and its easier to just check the left/right documents individually. This PR adds buttons to toggle between 3 modes:
You can also use
Ctrl <andCtrl >to hot switch between the Left/Right view.Ctrl dreturns to the default Diff view.Futher more, the
Ctrl dsets the offsets to 0, 0 (acts as a clear in case you want to quickly reset the offset)Futher Improvements
[ ] Show the names of the current document view (Left: file.pdf/ Right other.pdf / Diff)
[ ] Handle Missing pages (currently the diff doesn't handle missing pages and just shows changes for all subsequent pages)