Skip to content

Pass appcat_namespace in push-spks make target#8

Merged
mdnix merged 1 commit intomasterfrom
spks_support
Sep 16, 2025
Merged

Pass appcat_namespace in push-spks make target#8
mdnix merged 1 commit intomasterfrom
spks_support

Conversation

@mdnix
Copy link
Member

@mdnix mdnix commented Sep 15, 2025

No description provided.

@mdnix mdnix self-assigned this Sep 15, 2025
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit more context what's broken and what this fixes :D

Copy link
Member

@TheBigLee TheBigLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As simon says, a bit more context would be good for future reference

@mdnix
Copy link
Member Author

mdnix commented Sep 16, 2025

LGTM. As simon says, a bit more context would be good for future reference

Ah yes my bad.
I had to make this change because the syn-appcat namespace no longer exists for the spks target. Instead we have to pass the namespace spks-crossplane for the things we usually use syn-appcat for. For the other make targets it will still be set to syn-appcat by default which is defined as a global variable here: vshn/kindev#40

@mdnix mdnix merged commit cbeae11 into master Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants