Open
Conversation
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
Kidswiss
requested changes
Jan 30, 2026
Contributor
Kidswiss
left a comment
Kidswiss
left a comment
There was a problem hiding this comment.
Please adjust the CI pipeline to use the new justfile.
mikeshootzz
requested changes
Jan 30, 2026
Contributor
mikeshootzz
left a comment
mikeshootzz
left a comment
There was a problem hiding this comment.
Also: how do we handle having both Make and Justfiles? If we intend to switch I would remove the Makefiles, so we don't increase our buildfile-madness
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
| export KUBECONFIG={{kind_kubeconfig}} | ||
| if ! ({{vcluster_bin}} list | grep controlplane); then |
Contributor
There was a problem hiding this comment.
The Makefile checks both for an existing vcluster and whether the vcluster variable is enabled, while the justfile only checks for existence. This will cause vcluster to be created unconditionally, ignoring the default-disabled behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add justfile to replace makefiles