Hash environments and annotate to trigger pod restarts on changes#239
Open
Hash environments and annotate to trigger pod restarts on changes#239
Conversation
BacLuc
requested changes
Feb 13, 2026
Contributor
BacLuc
left a comment
BacLuc
left a comment
There was a problem hiding this comment.
I did not tests it, but it looks good except for the hashing.
container.EnvFrom, container.Env and template.Spec.ImagePullSecrets are all lists, so there already is a predefined order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new annotation
k8ify.restart-trigger-configwhich holds a hash of the secrets that are used in any of the containers in a pod.A change in the environments will result in a new hash, which will result in an annotation change which will trigger a restart when applied.
Note that this change will initially trigger a restart on pods that have not been annotated yet.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog