Open
Conversation
3 tasks
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
TheBigLee
requested review from
a team,
Kidswiss,
TheBigLee,
mdnix,
mikeshootzz and
zugao
and removed request for
a team
Kidswiss
approved these changes
Jan 30, 2026
Contributor
Kidswiss
left a comment
Kidswiss
left a comment
There was a problem hiding this comment.
We should get rid of the old makefile soon though. It'll be a pain to maintain both. But for now it probably makes sense to keep the Makefile, if there are bugs.
mikeshootzz
approved these changes
Jan 30, 2026
Contributor
+1 on this. |
zugao
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
/mergecomment.Link: vshn/appcat#579