Fix maintenance schedule mutation and day rollover bugs#590
Open
mikeshootzz wants to merge 2 commits intodevelopfrom
Open
Fix maintenance schedule mutation and day rollover bugs#590mikeshootzz wants to merge 2 commits intodevelopfrom
mikeshootzz wants to merge 2 commits intodevelopfrom
Conversation
This fixes mutation and maintenance scheduling on wrong days by replacing AddTime() with AddDuration() and moving offset logic into SetCustomMaintenanceSchedule
mikeshootzz
force-pushed
the
fix/maintenance-schedules
branch
from
1ad6ec8 to
2125f6c
Compare
3 tasks
Contributor
|
Contributor
|
This fixes an edge case with the rollover if the duration specified is greater or equal than 24 hours
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in maintenance schedule handling for services with PostgreSQL dependencies (Keycloak, Nextcloud):
AddTime()used a pointer receiver, mutating the originalTimeOfDay. This caused the parent service to also get the offset time.Replaces
AddTime()withAddDuration()that returns a day offset, and moves the offset logic intoSetCustomMaintenanceSchedule().Checklist
/mergecomment.Component PR: vshn/component-appcat#1072