Add rclone as encryption proxy for cnpg backups#580
Add rclone as encryption proxy for cnpg backups#580mikeshootzz wants to merge 5 commits intodevelopfrom
Conversation
|
744f14d to
778a995
Compare
|
|
|
91f1bb4 to
9e4d994
Compare
|
9e4d994 to
65be819
Compare
|
|
This deploys rclone alongside vshnpostgresqlcnpg to act as an intermediate encryption proxy
This allows the rclone release to be deleted to ensure backups can be disabled
This sets the server name so the backup can actually be restored.
a1c24e8 to
da5b93e
Compare
|
This uses the isOpenshift parameter to set the security contexts for openshift.
|
TheBigLee
left a comment
There was a problem hiding this comment.
LGTM.
Nitpick: Would have been nice to have the backup encryption layer optional
@TheBigLee I've thought about that. Since K8up-based backups are always encrypted it made the most sense to keep that behavior. |
@mdnix Yes. I tested it with about 5GB of data and that worked without issues. Of course, I wasn't able to test hundreds of GB. I'm still a bit concerned about the multipart upload limitations with rclone, but this should be enough for the foreseeable future. |
Could we please test this with usage that more closely reflects a customer's production workload? 5 GiB is not enough to test this imo. We need to know how reliable it is now, not then when in prod backups suddenly stop working. :) |
I'll do some more testing on the lab, sorry. |
|
This did not scale as expected and did not prove as viable for production use cases. |
Summary
This deploys rclone alongside vshnpostgresqlcnpg to act as an intermediate encryption proxy
Checklist
/mergecomment.Component PR: vshn/component-appcat#1058