Skip to content

Add rclone as encryption proxy for cnpg backups#580

Closed
mikeshootzz wants to merge 5 commits intodevelopfrom
cnpg/rcloneproxy
Closed

Add rclone as encryption proxy for cnpg backups#580
mikeshootzz wants to merge 5 commits intodevelopfrom
cnpg/rcloneproxy

Conversation

@mikeshootzz
Copy link
Contributor

@mikeshootzz mikeshootzz commented Jan 29, 2026

Summary

This deploys rclone alongside vshnpostgresqlcnpg to act as an intermediate encryption proxy

Checklist

  • Update tests.
  • Link this PR to related issues.
  • Merge with /merge comment.

Component PR: vshn/component-appcat#1058

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

This deploys rclone alongside vshnpostgresqlcnpg to act as an
intermediate encryption proxy
This allows the rclone release to be deleted to ensure backups can be
disabled
This sets the server name so the backup can actually be restored.
@mikeshootzz mikeshootzz marked this pull request as ready for review February 5, 2026 15:33
@mikeshootzz mikeshootzz requested review from a team, Kidswiss, TheBigLee, mdnix and zugao and removed request for a team February 5, 2026 15:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

This uses the isOpenshift parameter to set the security contexts for
openshift.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

@mikeshootzz mikeshootzz requested a review from Kidswiss February 6, 2026 13:36
Copy link
Member

@TheBigLee TheBigLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nitpick: Would have been nice to have the backup encryption layer optional

@mikeshootzz
Copy link
Contributor Author

LGTM. Nitpick: Would have been nice to have the backup encryption layer optional

@TheBigLee I've thought about that. Since K8up-based backups are always encrypted it made the most sense to keep that behavior.

Copy link
Member

@mdnix mdnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test how rclone holds up when there's actually a lot of data to backup? No limits are being set here so I'm assuming the charts default values apply here which are memory: "512Mi" and cpu: "25m".

@mikeshootzz
Copy link
Contributor Author

Did you test how rclone holds up when there's actually a lot of data to backup? No limits are being set here so I'm assuming the charts default values apply here which are memory: "512Mi" and cpu: "25m".

@mdnix Yes. I tested it with about 5GB of data and that worked without issues. Of course, I wasn't able to test hundreds of GB. I'm still a bit concerned about the multipart upload limitations with rclone, but this should be enough for the foreseeable future.

@mdnix
Copy link
Member

mdnix commented Feb 9, 2026

Did you test how rclone holds up when there's actually a lot of data to backup? No limits are being set here so I'm assuming the charts default values apply here which are memory: "512Mi" and cpu: "25m".

@mdnix Yes. I tested it with about 5GB of data and that worked without issues. Of course, I wasn't able to test hundreds of GB. I'm still a bit concerned about the multipart upload limitations with rclone, but this should be enough for the foreseeable future.

Could we please test this with usage that more closely reflects a customer's production workload? 5 GiB is not enough to test this imo. We need to know how reliable it is now, not then when in prod backups suddenly stop working. :)

@mikeshootzz
Copy link
Contributor Author

Did you test how rclone holds up when there's actually a lot of data to backup? No limits are being set here so I'm assuming the charts default values apply here which are memory: "512Mi" and cpu: "25m".

@mdnix Yes. I tested it with about 5GB of data and that worked without issues. Of course, I wasn't able to test hundreds of GB. I'm still a bit concerned about the multipart upload limitations with rclone, but this should be enough for the foreseeable future.

Could we please test this with usage that more closely reflects a customer's production workload? 5 GiB is not enough to test this imo. We need to know how reliable it is now, not then when in prod backups suddenly stop working. :)

I'll do some more testing on the lab, sorry.

@mikeshootzz
Copy link
Contributor Author

This did not scale as expected and did not prove as viable for production use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants