fix: bools where nil is interpreted as true can't have omitempty#388
Open
davidgubler wants to merge 1 commit intodevelopfrom
Open
fix: bools where nil is interpreted as true can't have omitempty#388davidgubler wants to merge 1 commit intodevelopfrom
davidgubler wants to merge 1 commit intodevelopfrom
Conversation
davidgubler
force-pushed
the
default-true-vs-omitempty
branch
from
bcba2b6 to
f0a87b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeletionProtection is a pointer to boolean with "omitempty" and a default of "true". This combination is broken in case the bool is set to "false", because the YAML mapper thinks that "false" is the default, thus ommitting the field; but then k8s thinks that "true" is the default (since the field is omitted). The result is that this is is always true, and it's completely impossible to set this field to "false" via the YAML mapper.
This PR fixes this by removing the "omitempty", which will make the YAML serializer also include "false" values instead of nil.
Component PR: vshn/component-appcat#774