Draft
Conversation
3 tasks
zugao
requested changes
Feb 20, 2025
Collaborator
zugao
left a comment
zugao
left a comment
There was a problem hiding this comment.
I would not set exists to true to all objects in the cluster. This can be disruptive and dangerous. It should be sufficient to just block out objects with the labels of ownerKind, ownerVersion, onwerGroup and ownerName. Line 54, 60, 66 and 72 would leave without changes
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
TheBigLee
force-pushed
the
pks-super-del-prot
branch
from
6bf8662 to
030d916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog