Skip to content

Conversation

@wazazaby
Copy link
Contributor

@wazazaby wazazaby commented Jan 31, 2025

Hi!

Improvement

  • On ErrUnexportedField, add the field name causing the problem to the error message

Other

  • Bump github.com/stretchr/testify/require to be able to use require.ErrorIs in tests
  • Use named helpers to check error presence in tests (require.NoError & require.Error)

@wazazaby wazazaby marked this pull request as ready for review January 31, 2025 09:17
@vrischmann
Copy link
Owner

The CI workflow is so old it doesn't even start.

Tested locally, LGTM, thanks

@vrischmann vrischmann merged commit a4fc8b5 into vrischmann:master Jan 31, 2025
0 of 4 checks passed
@wazazaby wazazaby deleted the feature/unexported-field-name-err branch January 31, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants