Remove OPENSSL_ENABLE_SHA1_SIGNATURES=1 as it is not required anymore #1418
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w666
force-pushed
the
feature-disable-sha-1
branch
from
adf3892 to
721387c
Compare
Contributor
|
JFOI: it (the SSL test) still breaks without it on AlmaLinux 9, but I can workaround it by setting the var myself before running |
Collaborator
Author
|
Ah, okay. It is fine with me to keep it. I just investigated a bit and ubuntu 24 has this disabled as well and github actions has been migrated to ubuntu 24, so I assumed it should work in other distros too. |
Contributor
I think it's still OK to proceed with the removal as you indicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1323