Open
Conversation
dmarion
requested changes
Jun 26, 2017
Makefile.am
Outdated
| # | ||
| # utils test | ||
| # | ||
| utils_test_SOURCES = test/utils_test.c test/vec_test.c |
Contributor
There was a problem hiding this comment.
one lib called libmemif.so please
src/socket.c
Outdated
|
|
||
| #define memif_min(a,b) a < b ? a : b | ||
|
|
||
| /* fifo is used as message queue, fifo will probably remain as it is |
Contributor
There was a problem hiding this comment.
for message queue please use linked list instead of fifo. i.e.:
typedef struct memif_msg_queue_elt_ {
memif_msg_t msg;
int fd;
struct memif_msg_queue_elt_ *next;
} memif_msg_queue_elt_t;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple mmeory management functions in vector and fifo folders.
header files cover basic functions and typedefs necessary for connection establishment.
implementation (and possibly demo app) will be added in next pull request