Open
Conversation
Compare: https://docs.opensearch.org/3.2/install-and-configure/configuring-opensearch/discovery-gateway-settings/ To: https://docs.opensearch.org/3.3/install-and-configure/configuring-opensearch/discovery-gateway-settings/ gateway.recover_after_nodes is now gone, probably due to: opensearch-project/OpenSearch#17357 The value of 0 here is documented to have been the default in 3.2 (and presumably earlier versions). This option may be replaceable by gateway.recover_after_data_nodes. Don't configure that as a default within puppet-opensearch, though; we don't need to mirror every upstream default here (indeed, the other gateway options are already unspecified).
Note that security manager was deprecated in 3.0 and (apparently) removed in at least 3.4. https://opensearch.org/blog/finding-a-replacement-for-jsm-in-opensearch-3-0/ Enabling this in 3.4 gives the error: java.lang.Error: A command line option has attempted to allow or enable the Security Manager. Enabling a Security Manager is not supported.
Author
|
The CI check failures are consistent with the pre-existing bug I mention above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Support opensearch 3.x.
This Pull Request (PR) fixes the following issues
Fixes #68
Notes and Caveats
This includes a change to the default config (remove
gateway.recover_after_nodes) which affects earlier opensearch versions. Since the value removed is the default, there should be no net change, but this may trigger restarts, depending on the value ofrestart_on_config_change.I have only put this in use enough to see that it seems to work. There may be some things for which I have failed to account.
I'm only working with opensearch 3.4, though I suspect other 3.x versions will work ok, since the changes are so minimal.
Installation via package only works on RHEL-based systems, not Debian-based systems. This is due to a pre-existing bug and is not specific to opensearch 3.x:
#55 which is actually an upstream bug; I commented on this here: opensearch-project/opensearch-build#5554 (comment)
Integration tests fail for the same reason as above.