Conversation
|
Sorry for the slow reply. This looks like a good plan to me. Not to be a pain, but we would want to see tests and docs before merging to master. There's also a few trivial bits of style that are causing the current checks to fail. So, if you have to time to finalize this patch, thanks very, much! If you don't, thanks very much... and I'll find some time to finalize and merge it. Cheers. |
|
Oh, and we ask you to sign the Contributor Licence Agreement (see below), too. It protects the open-sorcery of the project. |
|
Dear @vicinus, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Dear @vicinus, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
If you are interested I can also add documentation and spec tests. We have the problem, that for some of our customers the repo url format is of the following form, which isn't supported by this module:
https://mirror.example.com/elastic-co/packages/6.x/apt-customername