Added Redhat/CentOS package support #72
Conversation
Added params file to update the drbd package.
Fixed issue with creating multiple drbd resources in the node pair.
|
@midhlajvs please take a look as to why travis is failing |
AblionGE
left a comment
AblionGE
left a comment
There was a problem hiding this comment.
Hi,
Thanks for the update!
I think you just forgot to put $package_name here: https://github.com/voxpupuli/puppet-drbd/blob/master/manifests/resource.pp#L75
:)
|
Dear @midhlajvs, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
| ensure => running, | ||
| enable => $drbd::service_enable, | ||
| require => Package['drbd'], | ||
| require => Package[$::package_name], |
There was a problem hiding this comment.
| require => Package[$::package_name], | |
| require => Package[$drbd::package_name], |
|
Dear @midhlajvs, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
I think this one is obsolete with #140 ? |
6 participants
Pull Request (PR) description
This Pull Request (PR) fixes the following issues