Startup and initial setup fixes #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make startup {} parameters of a ressource manageble
by putting the startup block into the ressource definition. This makes
one able to configure parameters like wfc-timeout (waiting for conn.
timeout). The parameters are managed like the disk_ and net_parameters.
Member
|
The puppet code looks correct, but I can't judge the DRBD config since I've never used it. |
As the drbd user-guide states, the initial role select on the first node, needs to be done with "--force". Otherwise the role change will error out drbd: State change failed: Need access to UpToDate data reference: http://docs.linbit.com/docs/users-guide-8.4/#s-first-time-up Further to that, version after 8.4 don't have a WFConnection state - this state has been renamed to "Connecting".
ekohl
reviewed
Aug 16, 2018
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I can't judge the --force because I don't know drbd that well but otherwise it looks correct
| $fs_type = 'ext4', | ||
| $mkfs_opts = '', | ||
| $disk = undef, | ||
| $startup_parameters = undef, |
Member
There was a problem hiding this comment.
Could this be Optional[Hash[String, String]] $startup_parameters = undef instead?
| } | ||
|
|
||
| startup { | ||
| <% if @startup_parameters -%> |
Member
There was a problem hiding this comment.
Like `disk_parameters, I think this whole block should be hidden if no parameters are present.
|
Dear @diLLec, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes of this PR are fixing the initial setup procedure of the module. With startup options a wfc-timeout can be specified, so that the service enable does not hang an indefinite amount of time. Further the the initial ressource up needs a --force parameter (this may be an update in procedure for versions > 8.4).