Drop Puppet 5, add Puppet 7 and allow puppetlabs-concat 7.x

[markruys]

Pull Request (PR) description

• Support puppetlabs/concat 7.* and hence drop support for Puppet 5
• Add support for Puppet 7
• Clean up resources when ensure is set to absent (only partially implemented)

[smortex]

A few minor things to double check.

[smortex]

In order to access $amanda::client::ensure and $amanda::server::ensure we must include amanda::client and include amanda::server first.

[markruys]

Well, I'm not sure about this. I've tested (with Puppet 7), and the additional includes doesn't seem to be needed. Also, adding these includes changes the Amanda module behavior as the defaults are set to 'present'.

[smortex]

Well my point is that if the class amanda::server is not included, $amanda::server::ensure will be undef while the default value is 'present' when amanda::server is included… that's weird and seems fragile:

class { 'amanda::client':
}
# amanda::client include amanda
# `-> amanda include amanda::virtual
#     `-> amanda::virtual sees $amanda::server::ensure == undef
#                          and $amanda::client::ensure == 'present'
class { 'amanda::server':
}

class { 'amanda::server':
}
# amanda::server include amanda
# `-> amanda include amanda::virtual
#     `-> amanda::virtual sees $amanda::server::ensure == 'present'
#                          and $amanda::client::ensure == undef
class { 'amanda::client':
}

class { 'amanda':
}
# amanda include amanda::virtual
# `-> amanda::virtual sees $amanda::server::ensure == undef
#                      and $amanda::client::ensure == undef
class { 'amanda::client':
}
class { 'amanda::server':
}

I have no experience with amanda, but this does not look right 😨