Fix disklist with multiple configs #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disklists are managed and multiple configs are active, the disks are written in the wrong disklist file. Filtering on the target makes the disks go to the right disklist file. References (voxpupuli#12)
Author
|
@bastelfreak are you able to review? |
Member
|
Nothing jumps out at me as being a problem, but that's the reason we have tests. Can you write a test for this? |
Author
|
I'm not a Ruby developer. I tried to create a test by looking at the nginx module, but I don't know how to set up such a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
When disklists are managed and multiple configs are active, the disks are written in the wrong disklist file. Filtering on the target makes the disks go to the right disklist file.
This Pull Request (PR) fixes the following issues
References (#12)