Backwards incompatible refactor and restructure, composer, namespace #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up formatting of VoteSmart class.
The major change here is that you can no longer query directly from the constructor. The constructor now takes in 2 parameters: 1.) the output type, with a default of 'XML' 2.) the location in the global $_ENV array where to check for the API token supplied by VoteSmart is stored, with a default of 'VOTESMART_API_KEY' You can also set these directly using the methods setOutputType(), setEnvKey() and setApiToken().
…kwards compatible.
… outputType. Updated the README to contain more useful information.
…file Backwards incompatible refactor and restructure
…ace of VoteSmart. Moved Api class to src directory Created composer.json file and composer.lock files Updated .gitignore to ignore Composer created vendor directory
Set up as composer package, set up namespace and rename primary class
Author
|
Just a comment - this doesn't have any unit tests yet, and this can be further refactored to re-use existing code via composer. This also does not have composer instructions in the README yet, nor has the example.php file been updated. |
Author
|
Any chance this will get merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major changes here are backwards-incompatible with the current version but significantly increase its re-usability.
VoteSmart, and theVoteSmartclass was renamedApi