Skip to content

Improve error handling for DNS timeouts and clean terminal output #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrvcode wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve error handling for DNS timeouts and clean terminal output #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dnsvalidator/dnsvalidator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,8 @@ def resolve_address(server):
except dns.resolver.NXDOMAIN:
pass
except Exception as e:
output.terminal(Level.ERROR, server,
"Error when checking for DNS poisoning, passing")

error_msg = str(e).split(';')[0].split(':')[0]
output.terminal(Level.ERROR, server, "Connection error: {}".format(error_msg))
# Check for nxdomain on the rootdomain we're checking
try:
nxquery = "{rand}.{rootdomain}".format(
Expand Down Expand Up @@ -110,9 +109,7 @@ def resolve_address(server):
output.terminal(Level.ACCEPTED, server, "provided valid response")
valid_servers.append(server)
else:
output.terminal(Level.REJECTED, server,
"invalid response received")

output.terminal(Level.REJECTED, server, "Response mismatch or validation failed")

def main():
global goodip
Expand Down