Skip to content

Conversation

@mkuratczyk
Copy link
Contributor

Compilation fails on OTP 28.0.2:

== Compilation error in file lib/x509/asn1.ex ==
** (ArgumentError) no record AttributePKCS-10 found at /Users/mkuratczyk/.kerl/28.0.2/lib/public_key-1.18.2/include/PKCS-FRAME.hrl. Or the record does not exist or its entry is malformed or depends on other include files
    (elixir 1.18.4) lib/record/extractor.ex:56: Record.Extractor.extract_record/2
    lib/x509/asn1.ex:84: anonymous fn/1 in :elixir_compiler_9.__MODULE__/1
    (elixir 1.18.4) lib/enum.ex:987: Enum."-each/2-lists^foreach/1-0-"/2
    lib/x509/asn1.ex:68: (module)

With this change, it compiles and passes all tests on both 28.0.2 as well as 28.0.1.

I'm somewhat lost with all the public key related changes, so please make sure this is the right change. Thanks

@voltone
Copy link
Owner

voltone commented Jul 18, 2025

Hmm, in OTP 28 using the Attribute record is the right way to go about things, not quite sure why using AttributePKCS-10 was even working in 28.0.1. In OTP <28 this works because AttributePKCS-10 has the same shape as Attribute, even though this is not guaranteed by the ASN.1 compiler while compiling public_key. I suppose we can live with that, if all tests pass on all versions.

Can you just fix the linter error? Thanks!

@mkuratczyk
Copy link
Contributor Author

Linter should be happy now

@voltone voltone merged commit 88da98f into voltone:master Jul 18, 2025
6 checks passed
@voltone
Copy link
Owner

voltone commented Jul 18, 2025

Thanks!

@voltone
Copy link
Owner

voltone commented Jul 18, 2025

Released v0.9.2 to Hex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants