Fix signature algorithm for certificates signed by EdDSA keys #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, yes, I forgot about |
voltone
requested changes
Jun 27, 2025
Previously, when supplying an EdDSA key to functions in `X509.Certificate` that create certificates, the resulting certificate would contain AlgorithmIdentifiers for ECDSA signatures (eg. `ecdsa-with-sha256`), despite containing an EdDSA signature. Instead, we now check for Edwards curves being used in an ECPrivateKey in `X509.SignatureAlgorithm.new`, and return a proper AlgorithmIdentifier for that curve as specified by RFC 8410.
voltone
approved these changes
Jun 27, 2025
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when supplying an EdDSA key to functions in
X509.Certificatethat create certificates, the resulting certificate would contain AlgorithmIdentifiers for ECDSA signatures (eg.ecdsa-with-sha256), despite containing an EdDSA signature.Instead, we now check for Edwards curves being used in an ECPrivateKey in
X509.SignatureAlgorithm.new, and return a proper AlgorithmIdentifier for that curve as specified by RFC 8410.I've also added some unit tests to validate behaviour when working with EdDSA certificates and CRLs.