Fixes bug at chromosome boundaries, refactors the code, changed het_ratio calculation#6
Open
biomonika wants to merge 1 commit intovollgerlab:masterfrom
Open
Fixes bug at chromosome boundaries, refactors the code, changed het_ratio calculation#6biomonika wants to merge 1 commit intovollgerlab:masterfrom
biomonika wants to merge 1 commit intovollgerlab:masterfrom
Conversation
biomonika
commented
Mar 8, 2024
- fixes the bug discovered by Emily Xu; when at the chromosome boundaries, sometimes the clustering of variants would go across, creating large regions that include the coordinates from the two original chromosomes
- het_ratio is now the average across all second and first alleles (sum_second/(sum_first+sum_second))
…now the average across all second and first alleles
Collaborator
|
Thanks for the PR! But @glogsdon1 contributed this code to NucFreq so I'd like/need her input on these changes before accepting a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.