Skip to content

docs(process_lock): clarify Windows error handling for _is_pid_alive #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosenwang1018 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

docs(process_lock): clarify Windows error handling for _is_pid_alive #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions openviking/utils/process_lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,13 @@ def _is_pid_alive(pid: int) -> bool:
# Process exists but we can't signal it.
return True
except OSError:
# On Windows, os.kill(pid, 0) raises OSError (WinError 87 "The
# parameter is incorrect") for stale or invalid PIDs instead of
# ProcessLookupError. Treat this as "not alive" so stale lock
# files are correctly reclaimed.
# On Windows, os.kill(pid, 0) raises OSError for stale or invalid
# PIDs instead of ProcessLookupError. Common errors include:
# - WinError 87 "The parameter is incorrect"
# - WinError 11 "An attempt was made to load a program with an
# incorrect format"
# Treat any OSError as "not alive" so stale lock files are
# correctly reclaimed on Windows.
return False


Expand Down
Loading