-
Notifications
You must be signed in to change notification settings - Fork 97
Feat/BugFix: Preserve sidebar scroll position on navigation #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/BugFix: Preserve sidebar scroll position on navigation #452
Conversation
Signed-off-by: Lakshya Saxena <suntiwari3495@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @codeEvolveZenith345, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience by addressing a long-standing sidebar navigation issue where the scroll position was lost upon page changes. It introduces a robust mechanism to persist the sidebar's scroll state and simultaneously resolves two critical JavaScript errors that could lead to unexpected behavior or crashes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of preserving the sidebar scroll position and fixing a couple of critical JavaScript bugs. My review includes suggestions to make the new scroll-saving logic more robust by handling cases where the sidebar element might not be present, removing an unused function parameter and a leftover debug statement, and cleaning up some code formatting for better readability.
Signed-off-by: Lakshya Saxena <suntiwari3495@gmail.com>
|
/cc @Arhell |
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Bug fix
This PR fixes the sidebar navigation UX issue where clicking on any sidebar item causes the sidebar to scroll back to the top, making the selected item disappear from view. The fix:
change()function (assignment operator=changed to comparison==)i <= ull.length +1→i < ull.length)Fixes Bug: Sidebar scrolls to top on navigation, losing user's position #451
Before
Recording.2026-01-23.162159.mp4
Recording.2026-01-23.162549.mp4