-
Notifications
You must be signed in to change notification settings - Fork 97
docs: add Hierarchical Queue feature introduction #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: add Hierarchical Queue feature introduction #445
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @aaradhychinche-alt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's documentation by adding a comprehensive introduction to the Hierarchical Queue feature. It clarifies the core concept, explains why such a feature is crucial in modern cluster management, and differentiates between the available queue models, thereby providing a foundational understanding for users and administrators. This addition is a step towards improving the overall feature documentation on the website. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new documentation page introducing the Hierarchical Queue feature. The new page serves as a good high-level overview. I've suggested a couple of improvements to enhance clarity and accuracy. Specifically, I've recommended clarifying the description of the 'Capacity Queue' model to avoid confusion with the 'capability' property, and adding a link to the existing detailed user guide for hierarchical queues. These changes will make the documentation more accurate and helpful for users.
|
@Arhell @kevin-wangzefeng |
Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>
Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>
80c1991 to
0b7e34d
Compare
Summary
This PR adds an initial introduction and usage guide for the Hierarchical Queue feature under the Key Features section.
Changes
This is a follow-up to the Key Features foundation and contributes to improving feature documentation on the website.
Refs #330