Skip to content

Conversation

@aaradhychinche-alt
Copy link

Summary

The deviceshare plugin has an implicit dependency on the Predicate plugin, but this was not documented previously. As a result, users could enable deviceshare without enabling Predicate, leading to configuration errors and unexpected behavior.

Changes

  • Added a clear warning to the Predicate plugin documentation stating that the deviceshare plugin depends on it
  • Updated both English and Chinese versions of the plugins documentation to keep them in sync

Rationale

Making this dependency explicit helps users avoid misconfiguration and improves the robustness of the plugin ecosystem by clearly documenting required plugin relationships.

Fixes #410

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jessestutler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
Copy link
Collaborator

Welcome @aaradhychinche-alt! It looks like this is your first PR to volcano-sh/website 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello @aaradhychinche-alt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential misconfiguration issue by clarifying an implicit dependency between the deviceshare and Predicate plugins. By explicitly documenting that deviceshare requires Predicate to be enabled, it helps users avoid errors and improves the overall robustness and clarity of the plugin ecosystem.

Highlights

  • Documentation Update: Added a clear warning to the Predicate plugin documentation, explicitly stating that the deviceshare plugin has a dependency on it.
  • Multilingual Support: Ensured consistency by updating both the English and Chinese versions of the plugin documentation with the new dependency warning.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses an important documentation gap by adding a warning about the dependency of the deviceshare plugin on the Predicate plugin. The change is consistently applied to both English and Chinese documentation, which will help users avoid configuration errors. I've included a couple of minor suggestions to improve the conciseness of the new warning messages for better readability.

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 19, 2026
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@Arhell Arhell removed their assignment Jan 19, 2026
Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>
@aaradhychinche-alt aaradhychinche-alt force-pushed the docs/deviceshare-predicate-dependency branch from 9388ccb to 061d197 Compare January 19, 2026 09:30
@volcano-sh-bot volcano-sh-bot removed lgtm Indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jan 19, 2026
@aaradhychinche-alt
Copy link
Author

aaradhychinche-alt commented Jan 19, 2026

@Arhell the dco was failing i have committed now once more can you review the pr once more ? thank you !!

@Arhell
Copy link
Member

Arhell commented Jan 19, 2026

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@Arhell Arhell removed their assignment Jan 19, 2026
Copy link

@hajnalmt hajnalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


The Predicate Plugin calls the PredicateGPU with pod and nodeInfo as parameters to evaluate and pre-select jobs based on the results.

> ⚠️ **Warning**
Copy link

@hajnalmt hajnalmt Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure just putting this in makes any sense.

We shall add a section about the deviceshare plugin first and mention the dependecy there I think.

Copy link
Author

@aaradhychinche-alt aaradhychinche-alt Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arhell @hajnalmt what are your thoughts on whether we should keep this PR minimal with just the warning, or add a small DeviceShare plugin section in plugins.md for better context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Add deviceshare plugin dependency warning to Predicate plugin documentation

4 participants