-
Notifications
You must be signed in to change notification settings - Fork 31
feat: add helm chart release workflow and generation script #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @MahaoAlex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a streamlined and automated workflow for generating and packaging Helm charts. By adding a new Makefile target and a dedicated script, the process of preparing charts for release is standardized, ensuring consistent versioning and simplifying distribution for other developers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Makefile target and a shell script to automate the generation and packaging of Helm charts. This is a valuable addition for distributing the application. The script is well-structured, but I've identified a few issues related to script robustness and correctness. My review includes suggestions to improve temporary directory handling to prevent potential errors, and to fix and simplify the logic for updating chart metadata, which is currently incorrect and redundant. Addressing these points will make the script more reliable and maintainable.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage ? 34.34%
=======================================
Files ? 29
Lines ? 2533
Branches ? 0
=======================================
Hits ? 870
Misses ? 1540
Partials ? 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MahaoAlex <alexmahao319@gmail.com>
|
Hi @hzxuzhonghu , I've submitted this PR to automate the Helm Chart releases, and to make it fully functional, I would really appreciate your help with a small configuration step: Could you please help add a repository secret? It would be wonderful if you could:
TIA! |
|
Verified on my fork; the workflow will be active upon tag creation. Please feel free to reach out if any issues arise during the next release! |
Related to #165
The repository already contains archived content related to Charts. It is necessary to archive the build results of Helm Charts to facilitate other developers in installing them via Helm commands.
Archive URL: Archive URL here