Skip to content

Conversation

@MahaoAlex
Copy link
Contributor

Related to #165

The repository already contains archived content related to Charts. It is necessary to archive the build results of Helm Charts to facilitate other developers in installing them via Helm commands.

Archive URL: Archive URL here

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MahaoAlex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a streamlined and automated workflow for generating and packaging Helm charts. By adding a new Makefile target and a dedicated script, the process of preparing charts for release is standardized, ensuring consistent versioning and simplifying distribution for other developers.

Highlights

  • New Helm Chart Generation Target: A new generate-charts target has been added to the Makefile to automate the process of generating and packaging Helm charts.
  • Automated Helm Chart Script: A new shell script, hack/generate-charts.sh, has been introduced. This script handles the installation of the Helm CLI, copying of base charts, dynamic updating of version tags, and packaging of the final Helm chart.
  • Dynamic Versioning: The chart generation process now dynamically updates image tags and chart versions within values.yaml and Chart.yaml based on environment variables (AGENTCUBE_CHART_VERSION and AGENTCUBE_IMAGE_TAG), ensuring consistent versioning for releases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release_chart.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Makefile target and a shell script to automate the generation and packaging of Helm charts. This is a valuable addition for distributing the application. The script is well-structured, but I've identified a few issues related to script robustness and correctness. My review includes suggestions to improve temporary directory handling to prevent potential errors, and to fix and simplify the logic for updating chart metadata, which is currently incorrect and redundant. Addressing these points will make the script more reliable and maintainable.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ecea52a). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage        ?   34.34%           
=======================================
  Files           ?       29           
  Lines           ?     2533           
  Branches        ?        0           
=======================================
  Hits            ?      870           
  Misses          ?     1540           
  Partials        ?      123           
Flag Coverage Δ
unittests 34.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: MahaoAlex <alexmahao319@gmail.com>
@MahaoAlex
Copy link
Contributor Author

Hi @hzxuzhonghu ,

I've submitted this PR to automate the Helm Chart releases, and to make it fully functional, I would really appreciate your help with a small configuration step:

Could you please help add a repository secret? It would be wonderful if you could:

  1. Create a Fine-grained PAT: With 'Contents: Read & Write' permissions for the volcano-sh/helm-charts repository.
  2. Set up the Secret:
  • Name: HELM_CHARTER_TOKEN
  • Value: The token created above.

TIA!

@MahaoAlex
Copy link
Contributor Author

MahaoAlex commented Jan 23, 2026

Verified on my fork; the workflow will be active upon tag creation. Please feel free to reach out if any issues arise during the next release!
PTAL @kevin-wangzefeng @t2wang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants