Feat/52353 : Transcription for Remote Video#776
Open
SalahE-Ghannouch wants to merge 8 commits into3.xfrom
Open
Feat/52353 : Transcription for Remote Video#776SalahE-Ghannouch wants to merge 8 commits into3.xfrom
SalahE-Ghannouch wants to merge 8 commits into3.xfrom
Conversation
… into feat/54724
… into feat/52353
| * ) | ||
| */ | ||
| class TruncatedTextFormatter extends FormatterBase { | ||
|
|
Collaborator
There was a problem hiding this comment.
Configurable Character Limit:
public static function defaultSettings() {
return [
'character_limit' => 50,
] + parent::defaultSettings();
}|
|
||
| foreach ($items as $delta => $item) { | ||
| // Limit the text to 50 characters. | ||
| $text = mb_substr($item->value, 0, 50); |
Collaborator
There was a problem hiding this comment.
something like
$limit = $this->getSetting('character_limit');
for() {
Unicode::truncate($item->value, $limit, TRUE, TRUE);
}| } | ||
|
|
||
| $elements[$delta] = [ | ||
| '#markup' => $text, |
Collaborator
There was a problem hiding this comment.
Sanitize for xss
'#markup' => htmlspecialchars($text, ENT_QUOTES, 'UTF-8'),| return $elements; | ||
| } | ||
|
|
||
| } |
Collaborator
There was a problem hiding this comment.
add
public function settingsSummary() {
return [
$this->t('Character limit: @limit', ['@limit' => $this->getSetting('character_limit')]),
];
}
modules/vactory_remote_media_transcription/vactory_remote_media_transcription.module
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.