Skip to content

Conversation

@dogknowsnx
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

cc @tranzystorekk

Package is unusable w/o a font present on a base install
@tranzystorekk
Copy link
Contributor

I'm not sure fonts are a good thing to add as dependency, while I acknowledge labwc won't start without any font installed, it should be a user choice and responsibility to install/provide such things.

@dogknowsnx
Copy link
Contributor Author

I'm not sure fonts are a good thing to add as dependency, while I acknowledge labwc won't start without any font installed, it should be a user choice and responsibility to install/provide such things.

I beg to differ. The user could ignore and uninstall the font, but at least labwc would be usable and "complete" dep-wise (I deliberately picked a decent yet relatively small font package) - anyway, you're the maintainer, so please close if you really consider this change unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants