Rating model #22
Open
Rating model #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will need to think about validations of the dynamic ratings. Opportunity to refactor shop with numericality instead of regex. We will need to do more useful data manipulation than just replacing the value. We want averages of the most recent 5 dynamic ratings to start, but seed it as an admin. Potential opportunity to refactor private method to use only instance variables and no parameters. Using conditionals to ensure that blank dynamic ratings don't break shop validations. We rejected drying out the test with metaprogramming because it seemed too hard. Test has only tested that the value has changed, not the algorithm itself. https://app.asana.com/0/11389918903342/11518383302367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a new task to develop the algorithms for factoring dynamic ratings with the current rating.