Polynomial matrix multiplication and middle product via geometric evaluation-interpolation

.github/workflows/CI.yml

@@ -14,10 +14,9 @@ env:
   GLOBAL_MULTIPLIER: 1
 
 concurrency:
-  # group by workflow and ref; the last slightly strange component ensures that for pull
-  # requests, we limit to 1 concurrent job, but for the main branch we don't
+  # Group by workflow and ref, and to limit to 1 concurrent job except for main
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.ref != 'refs/heads/main' || github.run_number }}
-  # Cancel intermediate builds, but only if it is a pull request build.
+  # Cancel intermediate builds for pull requests
   cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
 
 jobs:
@@ -40,7 +39,7 @@ jobs:
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}"
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}" >> $GITHUB_ENV
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: "Setup"
         run: |
@@ -58,7 +57,7 @@ jobs:
           echo "MAKE=make -j$(expr $(nproc) + 1) --output-sync=target" >> $GITHUB_ENV
 
           # install FLINT dev version
-          git clone https://github.com/flintlib/flint.git
+          git clone --depth=1 https://github.com/flintlib/flint.git
           cd flint
           ./bootstrap.sh
           ./configure
@@ -90,10 +89,10 @@ jobs:
           $MAKE check
 
   ##############################################################################
-  # ubuntu 24.04, clang, flint 3.2.0
+  # ubuntu 24.04, clang, flint 3.4.0
   ##############################################################################
-  ubuntu-clang-flint320:
-    name: Ubuntu 24.04, clang, FLINT 3.2.0 (x10)
+  ubuntu-clang-flint340:
+    name: Ubuntu 24.04, clang, FLINT 3.4.0 (x10)
 
     runs-on: ubuntu-24.04
 
@@ -108,7 +107,7 @@ jobs:
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}"
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}" >> $GITHUB_ENV
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: "Setup"
         run: |
@@ -126,9 +125,8 @@ jobs:
           echo "MAKE=make -j$(expr $(nproc) + 1) --output-sync=target" >> $GITHUB_ENV
 
           # install FLINT dev version
-          git clone https://github.com/flintlib/flint.git
+          git clone --depth=1 https://github.com/flintlib/flint.git --branch v3.4.0 --single-branch
           cd flint
-          git checkout v3.2.0
           ./bootstrap.sh
           ./configure
           make
@@ -177,7 +175,7 @@ jobs:
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}"
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}" >> $GITHUB_ENV
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: "Setup"
         run: |
@@ -195,7 +193,7 @@ jobs:
           echo "MAKE=make -j$(expr $(nproc) + 1) --output-sync=target" >> $GITHUB_ENV
 
           # install FLINT dev version
-          git clone https://github.com/flintlib/flint.git
+          git clone --depth=1 https://github.com/flintlib/flint.git
           cd flint
           ./bootstrap.sh
           ./configure
@@ -246,7 +244,7 @@ jobs:
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}"
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}" >> $GITHUB_ENV
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: "Setup"
         run: |
@@ -308,7 +306,7 @@ jobs:
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}"
           echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}" >> $GITHUB_ENV
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: "Setup"
         run: |
@@ -326,7 +324,7 @@ jobs:
           echo "MAKE=gmake -j$(expr $(nproc) + 1) -l 10 --output-sync=target" >> $GITHUB_ENV
 
           # install FLINT dev version
-          git clone https://github.com/flintlib/flint.git
+          git clone --depth=1 https://github.com/flintlib/flint.git
           cd flint
           ./bootstrap.sh
           ./configure \
@@ -380,7 +378,7 @@ jobs:
   #    FLINT_TEST_MULTIPLIER: "0.5"
 
   #  steps:
-  #    - uses: actions/checkout@v4
+  #    - uses: actions/checkout@v6
 
   #    - name: "Setup MinGW"
   #      uses: msys2/setup-msys2@v2
@@ -444,7 +442,7 @@ jobs:
   #        echo "TIMEOUT=$TIMEOUT | Out-File -Append -FilePath $env:GITHUB_ENV"
   #      shell: powershell
 
-  #    - uses: actions/checkout@v4
+  #    - uses: actions/checkout@v6
 
   #    - name: "Setup cache for dependencies"
   #      uses: actions/github-script@v7
@@ -509,7 +507,7 @@ jobs:
   #        echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}"
   #        echo "FLINT_TEST_MULTIPLIER=${FLINT_TEST_MULTIPLIER}" >> $GITHUB_ENV
 
-  #    - uses: actions/checkout@v4
+  #    - uses: actions/checkout@v6
 
   #    - name: "Setup latest Alpine Linux"
   #      uses: jirutka/setup-alpine@v1

README.md

@@ -6,6 +6,7 @@ matrices, structured matrices, and their applications.
 Version 0.5
 
 Warning: the FLINT-based part of PML (flint-extras folder) is work in progress.
+Currently, it requires FLINT version 3.4.0 (November 2025) or later.
 
 ## Authors
 
@@ -61,7 +62,7 @@ Public License), see `flint-extras/COPYING_FLINT` for the license.
 ## Installation (FLINT-based version)
 
 The FLINT-based version is work in progress, and currently compiles with FLINT
-3.2.0 or later versions, including the current development version.
+3.4.0 or later versions, including the current development version.
 
 The build system is similar to (and directly derived from) FLINT's one. In
 short, for a standard configuration, the following steps should work:

flint-extras/configure.ac

@@ -979,7 +979,7 @@ FLINT_CHECK_MPFR_H(4,1,0)
 # check FLINT
 ################################################################################
 
-PML_CHECK_FLINT_H(3,2,0)
+PML_CHECK_FLINT_H(3,4,0)
 
 ################################################################################
 # check headers

flint-extras/pml.pc.in

@@ -7,6 +7,6 @@ Name: @PACKAGE_NAME@
 Description: Polynomial Matrix Library / FLINT
 Version: @PACKAGE_VERSION@
 URL: https://github.com/vneiger/pml
-Requires: gmp >= 6.2.1 mpfr >= 4.1.0 flint >= 3.2.0
+Requires: gmp >= 6.2.1 mpfr >= 4.1.0 flint >= 3.4.0
 Cflags: -I${includedir}
 Libs: -L${libdir} -lpml

flint-extras/src/nmod32_vec/profile/p-dot_mdot.c

@@ -35,9 +35,9 @@ void time_##fun(time_args targs, flint_rand_t state) \
     \
     double FLINT_SET_BUT_UNUSED(tcpu), twall; \
     \
-    TIMEIT_START \
+    TIMEIT_START; \
     res = _nmod32_vec_##fun(v1, v2, len, mod, arg); \
-    TIMEIT_STOP_VALUES(tcpu, twall) \
+    TIMEIT_STOP_VALUES(tcpu, twall); \
     \
     printf("%.2e", twall); \
     \
@@ -151,9 +151,9 @@ void time_dot_msolve_avx2(time_args targs, flint_rand_t state)
 
     double FLINT_SET_BUT_UNUSED(tcpu), twall;
 
-    TIMEIT_START
+    TIMEIT_START;
     res = _nmod32_vec_dot_msolve_avx2(v1, v2, len, mod.n);
-    TIMEIT_STOP_VALUES(tcpu, twall)
+    TIMEIT_STOP_VALUES(tcpu, twall);
 
     printf("%.2e", twall);
 
@@ -219,10 +219,10 @@ void time_##fun(time_args targs, flint_rand_t state)    \
                                                         \
     double FLINT_SET_BUT_UNUSED(tcpu), twall;           \
                                                         \
-    TIMEIT_START                                        \
+    TIMEIT_START;                                       \
     _nmod32_vec_##fun(res, mat, vec,                    \
                       nrows, len, len, mod);            \
-    TIMEIT_STOP_VALUES(tcpu, twall)                     \
+    TIMEIT_STOP_VALUES(tcpu, twall);                    \
                                                         \
     printf("%.2e", twall);                              \
                                                         \

flint-extras/src/nmod_extra.h

@@ -43,7 +43,7 @@ ulong inverse_mod_power_of_two(ulong p, int k);
 /* finds an element of order at least n                       */
 /* returns 0 if not found                                     */
 /*------------------------------------------------------------*/
-ulong nmod_find_root(long n, nmod_t mod);
+ulong nmod_find_root(ulong n, nmod_t mod);
 
 
 /*------------------------------------------------------------*/

flint-extras/src/nmod_extra/nmod_find_root.c

@@ -18,13 +18,13 @@
 /* finds an element of order at least n                       */
 /* returns 0 if not found                                     */
 /*------------------------------------------------------------*/
-ulong nmod_find_root(slong n, nmod_t mod)
+ulong nmod_find_root(ulong n, nmod_t mod)
 {
-    slong q;
-    for(q = 2; q < (slong) mod.n; q++)
+    ulong q;
+    for(q = 2; q < mod.n; q++)
     {
-        slong k = 1;
-        slong qk = q;
+        ulong k = 1;
+        ulong qk = q;
         while (qk != 1 && k < n)
         {
             qk = nmod_mul(qk, q, mod);