Skip to content

Conversation

@antonOO
Copy link

@antonOO antonOO commented Jan 5, 2021

[VAPI-4801] Fix deprecation links in the api-explorer

This change fixes the following three issues:
1. /api/session is not linked to /rest/com/vmware/cis/session (due to the lack
   of /cis in the new representation)
2. vmw-task=true (i.e. @TaskOnly) operations are not linked properly
3. the new token-exchange is not linked to the old one (there is no metadata
   for that link)

It also fixes the filename used in the deprecation path by removing the
'api_' prefix. This doesn't affect the api-explorer in any way.

Testing done: switched the 3 affected files on a deployment and verified
that operations are now properly linked.

dmitankin and others added 2 commits January 5, 2021 06:17
This change fixes the following three issues:
1. /api/session is not linked to /rest/com/vmware/cis/session (due to the lack
   of /cis in the new representation)
2. vmw-task=true (i.e. @TaskOnly) operations are not linked properly
3. the new token-exchange is not linked to the old one (there is no metadata
   for that link)

It also fixes the filename used in the deprecation path by removing the
'api_' prefix. This doesn't affect the api-explorer in any way.

Testing done: switched the 3 affected files on a deployment and verified
that operations are now properly linked.

Signed-off-by: Anton Obretenov <obretenova@vmware.com>
Amended erroneous test due to related changes.

Signed-off-by: Anton Obretenov <obretenova@vmware.com>
@vmwclabot
Copy link

@antonOO, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants