Conversation
✅ Deploy Preview for splinterdb canceled.
|
Collaborator
Author
|
Fixes #306 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_wait_inflightdid not match how it was used fromtest_do_read_batch.Also,
cache_assert_ungotwas attempting to implement an impossible check and the test was attempting to use that check.clockcache_assert_ungotwas trying to check only that the current thread did not hold a read lock on the specificied page. But, since CC_RC_WIDTH is only 4, multiple threads may share the same read counter and hence, even if one thread holds no locks, the read counter for a page may be non-zero. So I changedclockcache_assert_ungotto check that no thread has a read lock on the page, which matches its description.I then modified
cache_testto use the correctedcache_assert_ungot.