Skip to content

Conversation

@jhua-vmware
Copy link
Collaborator

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

sjiang-cb
sjiang-cb previously approved these changes May 30, 2025
@jhua-vmware jhua-vmware force-pushed the jhua/g11n-cldr-pattern branch 2 times, most recently from 2ceb6f9 to a050b62 Compare May 30, 2025 16:36
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (109ec8b) to head (1ab1dcd).
Report is 2 commits behind head on g11n-cldr-pattern.

Files with missing lines Patch % Lines
src/main/java/com/vmware/i18n/utils/JSONUtil.java 66.66% 6 Missing ⚠️
.../vmware/i18n/utils/timezone/CldrTimeZoneUtils.java 75.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             g11n-cldr-pattern    #3225      +/-   ##
=======================================================
- Coverage                78.11%   77.65%   -0.46%     
+ Complexity                 268      266       -2     
=======================================================
  Files                       29       29              
  Lines                     1878     1880       +2     
  Branches                   186      186              
=======================================================
- Hits                      1467     1460       -7     
- Misses                     327      335       +8     
- Partials                    84       85       +1     
Flag Coverage Δ
g11n-cldr-pattern 77.65% <73.80%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhua-vmware jhua-vmware changed the title migrate json-simple to json. migrate json-simple to json May 30, 2025
@jhua-vmware jhua-vmware force-pushed the jhua/g11n-cldr-pattern branch 2 times, most recently from 1bb09f4 to ab678ee Compare May 30, 2025 17:12
@jhua-vmware jhua-vmware force-pushed the jhua/g11n-cldr-pattern branch from ab678ee to 1ab1dcd Compare May 30, 2025 18:38
@jhua-vmware jhua-vmware merged commit ee3b9fc into g11n-cldr-pattern May 30, 2025
16 checks passed
@jhua-vmware jhua-vmware deleted the jhua/g11n-cldr-pattern branch May 30, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants