🐛 Improve webhook CA CertPool handling#1473
Open
bryanv wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Conversation
mikekim
approved these changes
Feb 20, 2026
mikekim
left a comment
mikekim
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for adding the extra log to capture the rejected certificate!
There was a potential race around the CA CertPool that we're using to validate the webhook requests. I doubt we were actually hitting this but we have very sporadic reports of this failing. Also to help debug any failures, dump the client cert when this does fail.
bryanv
force-pushed
the
bryanv/webhook-verify-client-cert-fixes
branch
from
952a4c1 to
c1cb830
Compare
Minimum allowed line rate is |
mikekim
approved these changes
Feb 20, 2026
abaruni
approved these changes
Feb 20, 2026
faisalabujabal
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
There was a potential race around the CA CertPool that we're using to validate the webhook requests. The global var that has the cert pool may not have been fully initialized before another request would use it.
Also to help debug any failures, dump the client cert when this does fail.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: