Fix for createVM with fastdeploy using vApp properties#1472
Open
hpannem wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Fix for createVM with fastdeploy using vApp properties#1472hpannem wants to merge 1 commit intovmware-tanzu:mainfrom
hpannem wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
Minimum allowed line rate is |
abaruni
requested changes
Feb 20, 2026
Contributor
abaruni
left a comment
abaruni
left a comment
There was a problem hiding this comment.
i am blocking this. this needs to be fixed in govmomi. also, this doesn't do anything for empty values which is the problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
When deploying a VM via fast deploy mode, vm-operator calls the VIM folder.CreateVM API directly with a VirtualMachineConfigSpec derived from the OVF image. The VIM API strictly validates vAppConfig boolean property values: both Value and DefaultValue must be "" or exactly "True"/"False" (case-sensitive). govmomi's toVAppConfig produces lowercase values (e.g. "false") from the OVF default attribute, which vSphere rejects with InvalidPropertyValue. This PR adds NormalizeVAppConfigBooleans to normalize non-empty boolean property values to the required case before passing the schema to CreateVM. The root cause is in govmomi's toVAppConfig and should ideally be fixed upstream.
Tested via unit tests.
Also, tested patching a setup and created same vm as specified in the bug. VM is created successfully.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # 3657670
Are there any special notes for your reviewer:
None
Please add a release note if necessary:
None